Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc-types-trace): use rpc-types Log in OtsReceipt #1261

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(rpc-types-trace): use rpc-types Log in OtsReceipt #1261

merged 1 commit into from
Sep 9, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Ref foundry-rs/foundry#8830 (comment)

OtsReceipt uses alloy_primitives::Log.

Solution

Use rpc_types_eth::Log instead of alloy_primitives::Log

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is indeed correct

https://otterscan.github.io/execution-apis/api-documentation/

image

@mattsse mattsse merged commit 1e9f45a into main Sep 9, 2024
30 checks passed
@mattsse mattsse deleted the yash/fix-log-ots-receipt branch September 9, 2024 21:12
@yash-atreya yash-atreya mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-atreya @mattsse