Add trait methods cumulative_gas_used and state_root to ReceiptResponse
#1275
Conversation
emhane
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
| /// The post-transaction state root (pre Byzantium) | ||
| /// | ||
| /// EIP98 makes this field optional. | ||
| fn state_root(&self) -> Option<&B256>; |
There was a problem hiding this comment.
we can ingore this because no longer useful
There was a problem hiding this comment.
when converting from ReceiptResponse to TransactionReceipt<T>, would it not be a bug to assume the field to be None for historic blocks?
There was a problem hiding this comment.
when converting from ReceiptResponse to TransactionReceipt
this isn't the purpose of this trait, this trait just serves the purpose of providing expected values
but I guess it doesn't really hurt to add this function, even if this is useless.
| /// Returns the cumulative gas used at this receipt. | ||
| fn cumulative_gas_used(&self) -> u128; |
| /// The post-transaction state root (pre Byzantium) | ||
| /// | ||
| /// EIP98 makes this field optional. | ||
| fn state_root(&self) -> Option<&B256>; |
There was a problem hiding this comment.
| fn state_root(&self) -> Option<&B256>; | |
| fn state_root(&self) -> Option<B256>; |
There was a problem hiding this comment.
not always a need to clone all the 32 bytes, the caller can decide
There was a problem hiding this comment.
this is at odds with the other trait functions. I'd like to unify this and return a copy
…esponse` (alloy-rs#1275) * Add trait methods cumulative_gas_used and state_root to ReceiptResponse * touchup --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Motivation
Use generic
ReceiptResponsetype in place ofalloy_rpc_types_eth::TransactionReceiptin reth RPCSolution
Adds trait methods
ReceiptResponse::cumulative_gas_usedandReceiptResponse::state_rootPR Checklist