feat(node-bindings): support appending extra args
#1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
DaniPopes
reviewed
Sep 17, 2024
DaniPopes
approved these changes
Sep 17, 2024
mattsse
approved these changes
Sep 17, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* feat(`node-bindings`): support appending args that are not part of the builder api * use OsString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, users cannot append any extra args to pass to
rethorgeth. We can only launch their respective instances with settings we have available in the builder api.Solution
Adds
args: Vec<OsString>to bothRethandGeththat get appended to thecmdbefore spawning the instance.PR Checklist