feat(consensus): Generic Block Type #1319
Conversation
refcell
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
crates/consensus/src/block.rs
Outdated
| /// A block body. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, RlpEncodable, RlpDecodable)] | ||
| #[rlp(trailing)] | ||
| pub struct BlockBody<T: Encodable + Decodable + Encodable2718 + Decodable2718> { |
There was a problem hiding this comment.
let's not require anything here
There was a problem hiding this comment.
I think we need Encodable + Decodable for the RlpEncodable, RlpDecodable auto-derive above right?
There was a problem hiding this comment.
hmm, I don't think it's needed? those derives will add bounds for respective impl blocks
crates/consensus/src/block.rs
Outdated
| /// Taken from [reth-primitives](https://github.com/paradigmxyz/reth) | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, RlpEncodable, RlpDecodable)] | ||
| #[rlp(trailing)] | ||
| pub struct Block<T: Encodable + Decodable + Encodable2718 + Decodable2718> { |
crates/consensus/src/block.rs
Outdated
| /// Taken from [reth-primitives](https://github.com/paradigmxyz/reth) | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, RlpEncodable, RlpDecodable)] | ||
| #[rlp(trailing)] | ||
| pub struct Block<T: Encodable + Decodable + Encodable2718 + Decodable2718> { |
There was a problem hiding this comment.
this should only use Encodable + Decodable
and it is expected that this is equivalent to
alloy/crates/eips/src/eip2718.rs
Line 219 in 21bc07e
see:
alloy/crates/consensus/src/transaction/envelope.rs
Lines 329 to 332 in 21bc07e
because this type is the p2p type
| /// Ethereum full block. | ||
| /// | ||
| /// Withdrawals can be optionally included at the end of the RLP encoded message. | ||
| /// | ||
| /// Taken from [reth-primitives](https://github.com/paradigmxyz/reth) |
There was a problem hiding this comment.
|
Think I've added what you're asking for but LMK if I'm missing something :) |
crates/consensus/src/block.rs
Outdated
| /// Block header. | ||
| pub header: Header, | ||
| /// Block body. | ||
| #[rlp(flatten)] |
There was a problem hiding this comment.
I don't think #[rlp(flatten)] works? this should probably be manual impl instead
* feat: consensus block type * fix: block type * fix: block type * alloc vec * bind to 2718 as well * fix: add requests * fix: remove 2718 encodables, docs * manual rlp --------- Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Description
Introduces a
Blocktype for thealloy-consensuscrate. See #1290