feat(consensus): Generic Block Type #1319
Open
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
requested changes
Sep 21, 2024
| /// A block body. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, RlpEncodable, RlpDecodable)] | ||
| #[rlp(trailing)] | ||
| pub struct BlockBody<T: Encodable + Decodable + Encodable2718 + Decodable2718> { |
There was a problem hiding this comment.
let's not require anything here
| /// Taken from [reth-primitives](https://github.com/paradigmxyz/reth) | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, RlpEncodable, RlpDecodable)] | ||
| #[rlp(trailing)] | ||
| pub struct Block<T: Encodable + Decodable + Encodable2718 + Decodable2718> { |
| pub ommers: Vec<Header>, | ||
| /// Block withdrawals. | ||
| pub withdrawals: Option<Vec<Withdrawal>>, | ||
| // TODO: add request with rlp encoding support |
There was a problem hiding this comment.
we should move the request's type here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a
Blocktype for thealloy-consensuscrate. See #1290