Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some warnings #1320

Merged
merged 1 commit into from
Sep 21, 2024
Merged

chore: fix some warnings #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/node-bindings/src/nodes/geth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,9 +648,8 @@ impl Geth {
// These tests should use a different datadir for each `geth` spawned.
#[cfg(test)]
mod tests {
use crate::utils::run_with_tempdir_sync;

use super::*;
use crate::utils::run_with_tempdir_sync;

#[test]
fn port_0() {
Expand Down
14 changes: 7 additions & 7 deletions crates/node-bindings/src/nodes/reth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ mod tests {
use crate::utils::run_with_tempdir_sync;

#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth() {
run_with_tempdir_sync("reth-test-", |temp_dir_path| {
let reth = Reth::new().data_dir(temp_dir_path).spawn();
Expand All @@ -543,7 +543,7 @@ mod tests {
}

#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth_sepolia() {
run_with_tempdir_sync("reth-test-", |temp_dir_path| {
let reth = Reth::new().chain_or_path("sepolia").data_dir(temp_dir_path).spawn();
Expand All @@ -553,7 +553,7 @@ mod tests {
}

#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth_dev() {
run_with_tempdir_sync("reth-test-", |temp_dir_path| {
let reth = Reth::new().dev().disable_discovery().data_dir(temp_dir_path).spawn();
Expand All @@ -563,7 +563,7 @@ mod tests {
}

#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth_dev_custom_genesis() {
run_with_tempdir_sync("reth-test-", |temp_dir_path| {
let reth = Reth::new()
Expand All @@ -578,7 +578,7 @@ mod tests {
}

#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth_dev_custom_blocktime() {
run_with_tempdir_sync("reth-test-", |temp_dir_path| {
let reth = Reth::new()
Expand All @@ -593,7 +593,7 @@ mod tests {
}

#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth_p2p_instances() {
run_with_tempdir_sync("reth-test-", |temp_dir_path| {
let reth = Reth::new().instance(100).data_dir(temp_dir_path).spawn();
Expand All @@ -611,7 +611,7 @@ mod tests {
// Tests that occupy the same port are combined so they are ran sequentially, to prevent
// flakiness.
#[test]
#[cfg(not(windows))]
#[cfg_attr(windows, ignore)]
fn can_launch_reth_custom_ports() {
// Assert that all ports are default if no custom ports are set
// and the instance is set to 0.
Expand Down
3 changes: 3 additions & 0 deletions crates/provider/src/provider/trait.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
//! Ethereum JSON-RPC provider.

#![allow(unknown_lints, elided_named_lifetimes)]

use crate::{
heart::PendingTransactionError,
utils::{self, Eip1559Estimation, EstimatorFunction},
Expand Down
1 change: 1 addition & 0 deletions crates/rpc-client/tests/it/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![allow(dead_code)]
#![allow(missing_docs)]

#[cfg(feature = "reqwest")]
mod http;
Expand Down