fix: use U256 for eth_getStorageAt #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Jan 19, 2024
crates/providers/src/provider.rs
Outdated
| .await | ||
| // Key is a QUANTITY according to the [spec](https://eth.wiki/json-rpc/API#eth_getstorageat). | ||
| // See: https://github.com/gakonst/ethers-rs/blob/b60c7fe1fea41a902e3b62dc716d45b326520fd0/ethers-providers/src/rpc/provider.rs#L674 | ||
| let key = U256::from_be_bytes(key.into()); |
There was a problem hiding this comment.
Should this be changed in the parameter?
There was a problem hiding this comment.
I think so, the user should do that, the storageKey type is intended for the server so the off spec format is also supported
we should use spec compliance here
mattsse
requested changes
Jan 19, 2024
crates/providers/src/provider.rs
Outdated
| .await | ||
| // Key is a QUANTITY according to the [spec](https://eth.wiki/json-rpc/API#eth_getstorageat). | ||
| // See: https://github.com/gakonst/ethers-rs/blob/b60c7fe1fea41a902e3b62dc716d45b326520fd0/ethers-providers/src/rpc/provider.rs#L674 | ||
| let key = U256::from_be_bytes(key.into()); |
There was a problem hiding this comment.
I think so, the user should do that, the storageKey type is intended for the server so the off spec format is also supported
we should use spec compliance here
DaniPopes
force-pushed
the
dani/fix-getstorageat
branch
from
ed0b73c
to
14ebfe6
Compare
mattsse
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix (maybe) foundry-rs/foundry#6855
See links in comments
Solution
PR Checklist