Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: make Header gas limit u64 #1333

Merged
merged 5 commits into from
Sep 26, 2024
Merged

consensus: make Header gas limit u64 #1333

merged 5 commits into from
Sep 26, 2024

Conversation

tcoratger
Copy link
Contributor

tcoratger
tcoratger commented Sep 23, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
tcoratger
tcoratger commented Sep 23, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do gas_limit and gas_used in one go

crates/consensus/src/header.rs Outdated Show resolved Hide resolved
tcoratger
tcoratger commented Sep 23, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@tcoratger
Copy link
Contributor Author

lets do gas_limit and gas_used in one go

@mattsse done

@tcoratger
Copy link
Contributor Author

@mattsse Nice bump, can we merge or any blocker?

mattsse
mattsse approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Sep 26, 2024
Merged via the queue into alloy-rs:main with commit b15d12b Sep 26, 2024
26 checks passed
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Oct 8, 2024
@tcoratger @mattsse @lwedge99
consensus: make Header gas limit u64 (alloy-rs#1333)
dc57edb 
* consensus: make Header gas limit u64

* fix clippy

* make gas used u64

* Update Cargo.toml

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @mattsse