-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(serde): encode optional types as Some #1348
Merged
mattsse
merged 3 commits into
alloy-rs:main
from
shekhirin:alexey/serde-quantity-opt-some
Sep 24, 2024
Merged
fix(serde): encode optional types as Some #1348
mattsse
merged 3 commits into
alloy-rs:main
from
shekhirin:alexey/serde-quantity-opt-some
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
September 24, 2024 14:46
mattsse
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
mattsse
approved these changes
Sep 24, 2024
It made me think, if that's a bug, do we want to have it on other modules too such as Lines 23 to 33 in cf9a98f
|
nice catch we should actually use the serialize some here, this doesn't matter for json but I guess it does for bincode |
mattsse
approved these changes
Sep 24, 2024
shekhirin
changed the title
fix(serde): encode optional quantity as Some
fix(serde): encode optional types as Some
Sep 24, 2024
mattsse
approved these changes
Sep 24, 2024
DaniPopes
approved these changes
Sep 24, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* fix(serde): encode optional quantity as Some * use serialize_some * fix in other types too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are binary formats such as bincode that care whether an
Option
is serialized usingserialize_some
or justserialize
, because they prepend the enum variant ofOption
as a starting byte.The tests were passing because JSON doesn't care about this.
Solution
Serialize
quantity::opt
asSome
when the value isSome
.PR Checklist