feat: deserialize requests #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
approved these changes
Sep 24, 2024
crates/json-rpc/src/request.rs
Outdated
Comment on lines
268
to
273
| // SAFETY: params is a ZST, so it's safe to fail to initialize it | ||
| unsafe { | ||
| params = Some(std::mem::transmute( | ||
| MaybeUninit::<Params>::uninit().assume_init(), | ||
| )) | ||
| } |
There was a problem hiding this comment.
I believe this is sound, iirc this should also work
std::mem::zeroed::<T>()
There was a problem hiding this comment.
changed it to this and removed unnecessary transmute
Comment on lines
+280
to
+281
| meta: RequestMeta::new(method.unwrap(), id.unwrap_or(Id::None)), | ||
| params: params.unwrap(), |
There was a problem hiding this comment.
these are fine, because checked above
|
@prestwich clippy does not like this -.- perhaps this works |
DaniPopes
approved these changes
Sep 24, 2024
|
It's not UB if it's zero-sized, fixable by just allowing the lint and removing the transmute since that lint is valid |
|
|
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* feat: deserialize requests * lint: clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deserialize request objects
Solution
PR Checklist