Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codes into execution witness #1352

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

0x00101010
Copy link
Contributor

Motivation

Return codes in ExecutionWitness

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context here @Rjected @rkrasiuk

Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit b5f04a7 into alloy-rs:main Sep 24, 2024
26 checks passed
@0x00101010
Copy link
Contributor Author

@mattsse curious about the release cadence here? When do we do another revm release and upgrade in reth accordingly?

lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants