Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: errors for responses #1369

Merged
merged 2 commits into from
Sep 26, 2024
Merged

feat: errors for responses #1369

merged 2 commits into from
Sep 26, 2024

Conversation

prestwich
Copy link
Member

  • Adds shortcut methods to instantiate response errors
  • Adds serialize_payload to the response objects to allow easy converting to the default Response

This is a breaking change, as it changes the ErrorPayload message to a Cow. However, it doesn't break anything in the library/

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these seem fine, the Cow makes sense, though only really for server POV

@mattsse mattsse added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 165eb67 Sep 26, 2024
26 checks passed
@mattsse mattsse deleted the prestwich/response-errors branch September 26, 2024 07:32
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Oct 8, 2024
@prestwich @lwedge99
feat: errors for responses (alloy-rs#1369)
29fb5db 
* feat: errors for responses

* lint: clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @mattsse