Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix more ci only #1402

Merged
merged 2 commits into from
Oct 19, 2024
Merged

tests: fix more ci only #1402

merged 2 commits into from
Oct 19, 2024

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Sep 30, 2024 •
edited
Loading

  • Disable more geth/reth tests when not run in CI
  • remove a bunch of bad-behavior init_tracing calls in tests to remove extraneous logs in test output

followup to #1393. That PR fixed cargo t this pr fixes cargo t --all-features

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich mentioned this pull request Sep 30, 2024
Draft
3 tasks
@prestwich
Copy link
Member Author

bump cc @klkvr

@prestwich prestwich self-assigned this Oct 19, 2024
@onbjerg onbjerg merged commit 25d2cf8 into main Oct 19, 2024
26 checks passed
@onbjerg onbjerg deleted the prestwich/more-ci-only branch October 19, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@jenpaff jenpaff Awaiting requested review from jenpaff

@shekhirin shekhirin Awaiting requested review from shekhirin

@rakita rakita Awaiting requested review from rakita

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@yash-atreya yash-atreya Awaiting requested review from yash-atreya

@klkvr klkvr Awaiting requested review from klkvr

@zerosnacks zerosnacks Awaiting requested review from zerosnacks

Assignees

@prestwich prestwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @onbjerg