Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-types-mev): add mev-share sse types #1419

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

SkandaBhat
Copy link
Contributor

@SkandaBhat SkandaBhat commented Oct 2, 2024

Motivation

Add mev-share-sse types from https://github.com/paradigmxyz/mev-share-rs/blob/main/crates/mev-share-sse/src/types.rs as referenced in this comment

fixes #1417

Solution

Ported the types into sse.rs.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@SkandaBhat SkandaBhat changed the title feat: add mev-share sse types feat(rpc-types-mev): add mev-share sse types Oct 2, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

crates/rpc-types-mev/src/lib.rs Outdated Show resolved Hide resolved
@mattsse
Copy link
Member

mattsse commented Oct 2, 2024

also please use cargo +nightly fmt

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming nit

crates/rpc-types-mev/src/lib.rs Outdated Show resolved Hide resolved
@mattsse mattsse merged commit 30dc912 into alloy-rs:main Oct 2, 2024
26 checks passed
@SkandaBhat SkandaBhat deleted the feature/mev-share-sse-types branch October 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move mev-share-sse types to alloy mev crate
2 participants