fix(provider): use wasmtimer for wasm32 target #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `std::time` library is mostly not supported on the wasm32 target. For this reason, we switch out some of these calls to use the crate `wasmtimer`.
b-zee
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
b-zee
added a commit
to b-zee/alloy
that referenced
this pull request
Oct 7, 2024
A follow up to PR alloy-rs#1426. A Tokio `sleep` is called, leading to a runtime error on WASM targets.
DaniPopes
pushed a commit
that referenced
this pull request
Oct 7, 2024
A follow up to PR #1426. A Tokio `sleep` is called, leading to a runtime error on WASM targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::timelibrary is mostly not supported on the wasm32 target.For this reason, we switch out some of these calls to use the crate
wasmtimer.My first pull request. I was in a bit of a hurry to make this PR, I will allocate more time tomorrow or next week.
@DaniPopes, let me know if there's anything I can do to ease merging this PR. We'll probably want to test this internally first, when we've upgraded to version
0.4.