Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing eth_getTransaction methods #1457

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Oct 12, 2024

closes #1450

@@ -534,6 +534,50 @@ pub trait Provider<T: Transport + Clone = BoxTransport, N: Network = Ethereum>:
self.client().request("eth_getTransactionByHash", (hash,)).into()
}

/// Returns the transaction by block hash and transaction index position.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change the docs to be in line with the other ones, e.g. "Get a transaction by a block number and its position in the block"

@onbjerg onbjerg added the enhancement New feature or request label Oct 12, 2024
@mattsse mattsse merged commit 8857646 into main Oct 16, 2024
26 checks passed
@mattsse mattsse deleted the matt/add-missing-get-transaction-calls branch October 16, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] add support for eth_getTransactionByBlockNumberAndIndex
2 participants