fix: Make RecommendedFillers generic over Network #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
DaniPopes
approved these changes
Oct 13, 2024
|
couldn't we just change the AT bound to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
RecommendedFillersgeneric overNetwork.Motivation
Associated type in the trait requires
TxFiller, which is generic overNetwork; it just hasEthereumas default.So it's impossible to implement custom fillers for a specific network, if they can't be implemented for
Ethereumas well.The solution is a bit awkward since now you can implement
RecommendedFillers<NetworkA>andRecommendedFillers<NetworkB>forNetworkA, but the pro is that it's not a breaking change.The alternative would be to introduce an associated type, but it would be breaking, since associated type defaults are unstable.
Solution
Make
RecommendedFillersgeneric overNetwork😅 .PR Checklist