Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: add more constraints to TxReceipt trait #1478

Merged
merged 5 commits into from
Oct 15, 2024
Merged

consensus: add more constraints to TxReceipt trait #1478

merged 5 commits into from
Oct 15, 2024

Conversation

tcoratger
Copy link
Contributor

mattsse
mattsse approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these make sense

wdyt @klkvr ?

crates/consensus/src/receipt/receipts.rs Outdated Show resolved Hide resolved
crates/consensus/src/receipt/mod.rs Outdated Show resolved Hide resolved
emhane
emhane approved these changes Oct 15, 2024
View reviewed changes
crates/consensus/src/receipt/mod.rs Outdated Show resolved Hide resolved
@tcoratger
Copy link
Contributor Author

@emhane I've just added Send and Sync :)

mattsse
mattsse requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic style nit

crates/consensus/src/receipt/any.rs Outdated Show resolved Hide resolved
crates/consensus/src/receipt/receipts.rs Outdated Show resolved Hide resolved
@mattsse mattsse merged commit 02ffc40 into alloy-rs:main Oct 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@emhane emhane emhane approved these changes

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoratger @mattsse @emhane @klkvr