Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When attempting to make a browser dapp with Dioxus I found that Alloy would not build with WebSocket support:
It is critical that Alloy supports building browser dapps with WebSocket support.
Solution
All that is required to fix this is adding missing function new() to WsConnect in
crates/transport-ws/src/wasm.rs
.With this fix I verified that Alloy could connect to a local node from the browser via WS.
Additionally I updated
scripts/check_no_std.sh
to check affected crates andws
feature. The target was changed fromriscv32imac-unknown-none-elf
towasm32-unknown-unknown
to facilitate this.PR Checklist