feat(rpc-types-trace/prestate): support disable_{code,storage} #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
approved these changes
Oct 21, 2024
Yeah, erigon's changes are also in the way erigontech/erigon#12384, and I'll file the similar changes for geth later |
mattsse
added a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Oct 23, 2024
based on alloy-rs/alloy#1538 --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some cases, we only need to track the ether balance/nonce changes, so no need to return the lonng code/storage back, so propose to add two new options:
disableCodeanddisableStorageto indicate wheather need to track code/storage or not.Solution
PR Checklist