-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eip1898: add unit tests to secure all conversions and impl #1544
Conversation
tcoratger
commented
Oct 21, 2024
•
edited
Loading
edited
- Full path under serde is used instead of import under cfg flag.
- Some functions are simplified.
- Unit tests are added to protect all implementations and conversions that can be tricky to mix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes are sensible and does not appear to contain breaking changes. Tests look good, ran tests against main
and verified there were no regressions.
@zerosnacks Yes exactly, that's exactly why I was doing this PR. My constant was that there were a lot of conversions in this file and that simplifications could be made in order to end up with exactly the same code while having a less wordy and error-prone implementation.
|
cc @yash-atreya pending final review, LGTM |