Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: add BadBlock type to debug_getbadblocks return type #1566

Merged
merged 10 commits into from
Oct 25, 2024
Merged

rpc: add BadBlock type to debug_getbadblocks return type #1566

merged 10 commits into from
Oct 25, 2024

Conversation

EdwardJES
Copy link
Contributor

@EdwardJES EdwardJES commented Oct 25, 2024 •
edited by yash-atreya
Loading

This PR adds BadBlock as a new type and adds it to the return type to debug_getBadBlocks. Closes #1560

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@EdwardJES EdwardJES marked this pull request as draft October 25, 2024 05:33
@EdwardJES EdwardJES marked this pull request as ready for review October 25, 2024 05:38
mattsse
mattsse requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr should be limited to the new badblock type and not change any existing types.

crates/rpc-types-eth/src/block.rs Outdated Show resolved Hide resolved
@EdwardJES
Copy link
Contributor Author

Thank you, @mattsse. Have addressed the comments.

@EdwardJES
Copy link
Contributor Author

Fixing clippy now.

@mattsse mattsse merged commit 3fc5943 into alloy-rs:main Oct 25, 2024
26 checks passed
@yash-atreya yash-atreya mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-RPC types do not agree with Ethereum's OpenRPC spec
2 participants
@EdwardJES @mattsse