feat: embed consensus header into RPC #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
approved these changes
Oct 28, 2024
Comment on lines
+5
to
+11
| /// Block header representation with certain fields made optional to account for possible | ||
| /// differencies in network implementations. | ||
| #[cfg_attr(any(test, feature = "arbitrary"), derive(arbitrary::Arbitrary))] | ||
| #[derive(Clone, Debug, Default, PartialEq, Eq, Hash)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| #[cfg_attr(feature = "serde", serde(rename_all = "camelCase"))] | ||
| pub struct AnyHeader { |
There was a problem hiding this comment.
ah yeah we def need this for foundry
|
|
||
| type TransactionRequest = WithOtherFields<TransactionRequest>; | ||
|
|
||
| type TransactionResponse = WithOtherFields<Transaction>; | ||
|
|
||
| type ReceiptResponse = AnyTransactionReceipt; | ||
|
|
||
| type HeaderResponse = Header; | ||
| type HeaderResponse = alloy_rpc_types_eth::Header<Self::Header>; |
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
sizeis moved from block body to header. we don't have a way to distinct which fields in RPC belong to block body vs header but moving size to header leaves RPC block fields as header + flattened body which makes sense imorpc_types_eth::Headernow wraps an inner consensus header and additionaly storeshash,totalDifficultyandsizewhich are RPC-specificAnyHeaderin alloy-consensus crate which is the same asalloy_consensus::HeaderwithmixHashandnoncebeing optional.HeaderResponsetrait is removed andNetwork::HeaderResponseis now required to implementAsRef<Network::Header>making it possible to simply use methods from consensusBlockHeadertrait everywhere