Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relay types #1577

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix: relay types #1577

merged 5 commits into from
Oct 28, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 28, 2024

mattsse
mattsse approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems correct:

https://github.com/attestantio/go-builder-client/blob/master/api/deneb/submitblockrequest.go

I think we can also remove SubmitBlockRequest to avoid confusion?

@klkvr
Copy link
Member Author

klkvr commented Oct 28, 2024

I think we can also remove SubmitBlockRequest to avoid confusion?

yep it's removed

@klkvr klkvr merged commit c4f3543 into main Oct 28, 2024
26 checks passed
@klkvr klkvr deleted the klkvr/fix-flashbots-types branch October 28, 2024 15:49
@klkvr klkvr mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse