Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alloy-provider): get_block_by_number arg #1582

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

steph-rs
Copy link
Contributor

Motivation

Different args in alloy-provider crate:

    /// Gets a block by its [BlockHash], with full transactions or only hashes.
    async fn get_block_by_hash(
        &self,
        hash: BlockHash,
        kind: BlockTransactionsKind,    <--
    )
    ...
    /// Get a block by its number.
    // TODO: Network associate
    async fn get_block_by_number(
        &self,
        number: BlockNumberOrTag,
        hydrate: bool,                  <--
    )

Solution

Changing hydrate argument to kind to make methods symmetrical.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. noting that this is a breaking change.

@onbjerg onbjerg merged commit abb4dd4 into alloy-rs:main Oct 29, 2024
@onbjerg onbjerg mentioned this pull request Oct 29, 2024
3 tasks
onbjerg added a commit that referenced this pull request Oct 29, 2024
## Motivation

I was hasty in merging #1582, checking the status through an external interface said it was good to merge, when in fact it was not.

## Solution

Fix the remaining tests and unbreak CI. Sorry

## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants