Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current implementation has a bug:
alloy/crates/consensus/src/transaction/eip4844.rs
Line 889 in 193bcd8
Here we need to use
..header.payload_length
Also we didn't override
rlp_header_signer
for eip4844 tx with sidecar which resulted in invalid rlp in some edge casesSolution
Fix decoding methods and change them to use common flow of all other such methods without temporary buffer creation
PR Checklist