Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RLP for TxEip4844 #1596

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: RLP for TxEip4844 #1596

merged 2 commits into from
Oct 31, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 30, 2024

Motivation

Current implementation has a bug:

let chunk = &mut &buf[..remaining_len];

Here we need to use ..header.payload_length

Also we didn't override rlp_header_signer for eip4844 tx with sidecar which resulted in invalid rlp in some edge cases

Solution

Fix decoding methods and change them to use common flow of all other such methods without temporary buffer creation

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit 408770d into main Oct 31, 2024
26 checks passed
@mattsse mattsse deleted the klkvr/fix-4844-rlp branch October 31, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants