feat(serde): StorageKeyKind
#1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
requested changes
Oct 31, 2024
crates/serde/src/storage.rs
Outdated
| #[serde(from = "U256", into = "String")] | ||
| pub struct JsonStorageKey(pub B256); | ||
| #[derive(Clone, Copy, Debug, Default, PartialEq, Eq, Serialize)] | ||
| #[serde(into = "String")] |
There was a problem hiding this comment.
@Rjected isn't all of this now just serde(untagged) ?
mattsse
requested changes
Nov 5, 2024
crates/serde/src/storage.rs
Outdated
Comment on lines
12
to
13
| #[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub enum StorageKeyKind { |
There was a problem hiding this comment.
I think this is now just #[serde(untagged)] then we no longer need any serialization on JsonStorageKey
mattsse
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1553
Solution
Introduce the enum
StorageKeyKindwith variantsHash(B256)andNumber(U256). Used inJsonStorageKey.Tries to deserialize a string into the
Hashvariant first.PR Checklist