fix: receipt status serde #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
approved these changes
Nov 2, 2024
| #[cfg_attr(any(test, feature = "arbitrary"), derive(arbitrary::Arbitrary))] | ||
| #[cfg_attr(feature = "serde", serde(rename_all = "camelCase"))] | ||
| #[doc(alias = "TransactionReceipt", alias = "TxReceipt")] | ||
| pub struct Receipt<T = Log> { | ||
| /// If transaction is executed successfully. | ||
| /// | ||
| /// This is the `statusCode` | ||
| #[cfg_attr(feature = "serde", serde(alias = "root"))] | ||
| #[cfg_attr(feature = "serde", serde(flatten))] |
There was a problem hiding this comment.
ah right alias doesn't quite work here
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ref foundry-rs/foundry#9239 (comment)
Right now we will fail to deserialize receipt if both
statusandrootare present.Solution
Update serde impl to deserialize
Eip658Valueas untagged enum withstatusandroot. We preferstatusas it is more common and adds useful context.This also allowed to just use
serde(flatten)for status field and remove manual serde for receipt.PR Checklist