fix: serde for AnyTxEnvelope
#1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
klkvr
force-pushed
the
klkvr/fix-any-serde
branch
6 times, most recently
from
ee2893c
to
9c26e82
Compare
klkvr
force-pushed
the
klkvr/fix-any-serde
branch
from
9c26e82
to
8af00ad
Compare
mattsse
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RIght now
AnyTxTypeis serialized as number but we should use quantity for it.Also,
MaybeTaggedEnvelopewould correctly deserialize legacy transaction if map has all its fields and a different type flag. This is the case for deposit transaction breaking its deserialization inAnyTxEnvelopecontextSolution
Serialize and deserialize
AnyTxTypeasU8Fail
Untaggedvariant deserialization iftypeis present.Also fixed deserialization of transaction fields in
Transactiontrait impl. We had incorrect name forgasand didn't use quantity when deserializing integers.PR Checklist