fix(provider): make Caller EthCall specific
#1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
klkvr
reviewed
Nov 5, 2024
Comment on lines
32
to
36
| fn call( | ||
| &self, | ||
| method: Cow<'static, str>, | ||
| params: Params, | ||
| ) -> TransportResult<ProviderCall<T, serde_json::Value, Resp>> { | ||
| params: EthCallParams<'_, N>, | ||
| ) -> TransportResult<ProviderCall<T, EthCallParams<'static, N>, Resp>> { |
There was a problem hiding this comment.
would be nice to have either enum for method or just separate call/estimate_gas methods on trait so that custom implementations don't have to match on strings
klkvr
reviewed
Nov 5, 2024
Comment on lines
14
to
+18
| pub struct EthCallParams<'req, N: Network> { | ||
| data: &'req N::TransactionRequest, | ||
| data: Cow<'req, N::TransactionRequest>, | ||
| block: Option<BlockId>, | ||
| overrides: Option<&'req StateOverride>, | ||
| overrides: Option<Cow<'req, StateOverride>>, | ||
| } |
There was a problem hiding this comment.
curious what's usecase for Cow and builder methods here? I'd expect that this wouldn always be constructed through EthCall builders and both users and custom Caller implementations wouldn't need to constructor/change this type manually?
klkvr
approved these changes
Nov 5, 2024
mattsse
approved these changes
Nov 5, 2024
klkvr
reviewed
Nov 5, 2024
| Resp: RpcReturn, | ||
| { | ||
| /// Method that needs to be implemented to convert to a `ProviderCall`. | ||
| /// | ||
| /// This method handles serialization of the params and sends the request to relevant data | ||
| /// source and returns a `ProviderCall`. | ||
| /// This method sends the request to relevant data source and returns a `ProviderCall`. | ||
| fn call( |
There was a problem hiding this comment.
@yash-atreya could we make Caller::call always output Bytes and estimate_gas would output u64? Resp generic might be tricky to deal with in custom implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1471
Solution
dataandoverridesfields inEthCallParamsto beCow.EthCallParamsas arg inCaller.call(&self, method, params: EthCallParams<'_, N>).ProviderCallshould be used overEthCallParamsPR Checklist