fix: serde for transactions #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
approved these changes
Nov 7, 2024
Comment on lines
+277
to
+278
| /// Helper struct which will be flattened into the transaction and will only contain `gasPrice` | ||
| /// field if inner [`TxEnvelope`] did not consume it. |
There was a problem hiding this comment.
yep, it relies on it being deserialized after the inner tx. if it was just a field it would always be deserialized and consumed before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes all transactions to always serialize
to: nullinstead of omitting the field.Adds deprecated
gaaPricefield to RPC transaction which is only serialized if inner tx does not have its owngasPriceSolution
PR Checklist