fix(network): impl NetworkWallet<AnyNetwork>
#1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
klkvr
requested changes
Nov 7, 2024
There was a problem hiding this comment.
I don't think we need a separate type here given that signable transactions set is still the same
In op-alloy I've done this https://github.com/alloy-rs/op-alloy/blob/01f11b4747f3b533f947be19188099cb21182a1a/crates/network/src/lib.rs#L198 which allows to reuse EthereumWallet for OP as well
|
yash-atreya
changed the title
network): AnyNetworkWalletnetwork): impl Network<AnyNetwork>
yash-atreya
changed the title
network): impl Network<AnyNetwork>network): impl NetworkWallet<AnyNetwork>
klkvr
reviewed
Nov 7, 2024
klkvr
reviewed
Nov 7, 2024
klkvr
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #1460,
AnyTxEnvelopeandAnyTypedTransactionwere introduced. These are now being used inAnyNetwork.This made initializing an
AnyNetworkprovider with theEthereumWalletwallet filler incompatible as it signsTypedTransactionand returns theTxEnvelope.Solution
Implmenent
NetworkWallet<AnyNetwork>forEthereumWalletthat signAnyTypedTransactionsPR Checklist