Add trait method Transaction::is_dynamic_fee
#1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
emhane
changed the title
Transaction::is_dynamic_feeTransaction::is_dynamic_fee
mattsse
requested changes
Nov 12, 2024
Comment on lines
+150
to
+151
| self.fields.get_deserialized::<U128>("maxFeePerGas").is_some() | ||
| || self.fields.get_deserialized::<U128>("maxFeePerBlobGas").is_some() |
There was a problem hiding this comment.
how? I thought ab it too, but it would be incorrect for eg deposit tx to do smthg like self.ty() > 1
There was a problem hiding this comment.
oh, yeah we'd only catch known types, which defeats the purpose here
mattsse
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate reth utility method paradigmxyz/reth#12437 (comment)
Solution
Adds trait method
alloy_consensus::Transaction::is_dynamic_feePR Checklist