Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: add BlockWithParent #1650

Merged
merged 2 commits into from
Nov 16, 2024
Merged

consensus: add BlockWithParent #1650

merged 2 commits into from
Nov 16, 2024

Conversation

tcoratger
Copy link
Contributor

As per:

We need to introduce BlockWithParent struct in alloy to use it directly in reth.

mattsse
mattsse requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add this to where BlockNumHash is defined, in alloy-eips, doesn't quite fit, but seems appropriate

@tcoratger
Copy link
Contributor Author

I think we can add this to where BlockNumHash is defined, in alloy-eips, doesn't quite fit, but seems appropriate

@mattsse fixed

@mattsse mattsse merged commit 39ae9af into alloy-rs:main Nov 16, 2024
26 checks passed
@tcoratger tcoratger mentioned this pull request Nov 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @mattsse