Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modifiy ReceiptWithBloom and associated impls to use with Reth #1672

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: modifiy ReceiptWithBloom and associated impls to use with Reth #1672

wants to merge 15 commits into from
+185 −136

Conversation

royvardhan
Copy link
Contributor

mattsse
mattsse reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far,

what's missing?

cc @klkvr

crates/rpc-types-eth/src/transaction/receipt.rs Outdated Show resolved Hide resolved
@royvardhan royvardhan marked this pull request as ready for review November 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@royvardhan @mattsse @klkvr