Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modifiy ReceiptWithBloom and associated impls to use with Reth #1672

Merged
merged 15 commits into from
Nov 25, 2024
Merged

feat: modifiy ReceiptWithBloom and associated impls to use with Reth #1672

merged 15 commits into from
Nov 25, 2024

Conversation

royvardhan
Copy link
Contributor

mattsse
mattsse reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far,

what's missing?

cc @klkvr

crates/rpc-types-eth/src/transaction/receipt.rs Outdated Show resolved Hide resolved
@royvardhan royvardhan marked this pull request as ready for review November 22, 2024 17:53
@royvardhan
Copy link
Contributor Author

@mattsse I think we are good.

mattsse
mattsse approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
this should be simple to port to op-alloy, I believe

@royvardhan
Copy link
Contributor Author

lgtm,

this should be simple to port to op-alloy, I believe

On it.

@mattsse mattsse merged commit 4284bb5 into alloy-rs:main Nov 25, 2024
26 checks passed
@royvardhan royvardhan mentioned this pull request Nov 26, 2024
Merged
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this pull request Nov 28, 2024
@royvardhan @klkvr @mattsse
feat: bump alloy (#314)
e8225cc 
Ref:
alloy-rs/alloy#1672 (review)

---------

Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@elfedy elfedy mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@royvardhan @mattsse @klkvr