feat: EIP-7685 requests helpers #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
requested changes
Nov 28, 2024
crates/eips/src/eip7685.rs
Outdated
Comment on lines
38
to
39
| request: impl IntoIterator<Item = u8>, | ||
| request_type: u8, |
There was a problem hiding this comment.
can we flip the order here?
feels more natural to have the correct order
also I assume there's a more efficient way to prepend a Bytes with a single byte, perhaps @DaniPopes knows?
There was a problem hiding this comment.
Nope Bytes is immutable so it must be done at construction using a vec
mattsse
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds constant
DEPOSIT_REQUEST_TYPEsimilarly tohttps://github.com/alloy-rs/alloy/blob/eb8fb7133e19248b8ba3cda009b3f63deacce0c5/crates/eips/src/eip7002.rs#L18-L20
and https://github.com/alloy-rs/alloy/blob/eb8fb7133e19248b8ba3cda009b3f63deacce0c5/crates/eips/src/eip7251.rs#L15-L17
And a helper
Requests::push_request_with_typewhich appends request data to the given request typSolution
PR Checklist