fix: remove Borrow
impl for RPC receipt
#1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Based on #1719
I've added this impl to support a more generic
AnyReceiptEnvelope
alloy/crates/rpc-types-eth/src/log.rs
Lines 156 to 160 in 67576f9
However, it is in fact incorrect as
Borrow
shouldn't be implemented in this caseSolution
This PR reverts changes including this impl and changes
AnyReceiptEnvelope
back to always holding aReceipt<T>
If we want to still support
AnyReceiptEnvelope
being generic over arbitrary receipt types, we'd need to either addAsRef<Self> for alloy_primitives::Log
and use it instead or introduce a separateLog
trait to replace such bounds with:alloy/crates/consensus/src/receipt/receipts.rs
Lines 27 to 29 in 67576f9
PR Checklist