fix: use feeHistory when estimating blob fee
#1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
mattsse
approved these changes
Dec 7, 2024
| .map(Into::into) | ||
| .ok_or(RpcError::UnsupportedFeature("eip4844")) | ||
| .base_fee_per_blob_gas | ||
| .last() |
There was a problem hiding this comment.
makes sense, the last entry should be the estimated next one
yeah let's mark them as deprecated and introduce one with the update fraction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With EIP-7691, we can no longer rely on
BlockHeader::next_block_blob_feeas it will start producing invalid values once the update fraction changes.This PR changes blob fee filler to use
feeHistoryinstead to obtain those values from RPC.I think we should also consider either deprecating
BlockHeader::next_block_excess_blob_gas/BlockHeader::next_block_blob_feemethods or making them accept an update fraction parameterPR Checklist