Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport): allow RetryPolicy to be set via layer #1790

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix(transport): allow RetryPolicy to be set via layer #1790

merged 2 commits into from
Dec 13, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Currently, we cannot set custom retry policies (RetryPolicy) as the RetryBackoffService defaults to the RateLimitRetryPolicy type here:

alloy/crates/transport/src/layers/retry.rs

Line 81 in 663e926

policy: RateLimitRetryPolicy,
.

Solution

Make the RetryBackoffLayer and RetryBackoffService generic over RetryPolicy with RateLimitRetryPolicy as the default.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yash-atreya yash-atreya enabled auto-merge (squash) December 13, 2024 11:32
@yash-atreya yash-atreya merged commit 4de90e9 into main Dec 13, 2024
26 checks passed
@yash-atreya yash-atreya deleted the yash/fix-retry-layer branch December 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-atreya @mattsse