feat: add info tx types #1793
Merged
feat: add info tx types #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
reviewed
Dec 13, 2024
| block_number: self.block_number, | ||
| // We don't know the base fee of the block when we're constructing this from | ||
| // `Transaction` | ||
| base_fee: None, |
There was a problem hiding this comment.
should it take base_fee as an argument?
There was a problem hiding this comment.
we set this via the additional builder fn: into().with_base_fee()
klkvr
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream's reth's
TransactionMetatypeand moves the TxInfo type to consensus from rpc.
these two types are almost identical, but info has optional fields because this is primarily used in rpc where the block context is optional.
naming is a bit horrible, but we can break this if we can come up with a better way to deal with this, perhaps introducing BlockContext or something similar