Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse v3 envelope in v4 envelope #1795

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Dec 13, 2024

Motivation

This is similar to how we handle ExecutionPayloads and makes it clear which fields were actually added in v4

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this is better

@mattsse mattsse merged commit 743a041 into main Dec 13, 2024
26 checks passed
@mattsse mattsse deleted the klkvr/use-envelope-v3-internally branch December 13, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants