Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc-types): do not deny additional fields #195

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(rpc-types): do not deny additional fields #195

merged 2 commits into from
Feb 9, 2024

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Feb 9, 2024

Motivation

We were explicitly denying unknown fields on TransactionRequest.

Solution

Support them, as we already use OtherFields.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@Evalir Evalir mentioned this pull request Feb 9, 2024
Merged
mattsse
mattsse approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is not helpful

@mattsse mattsse merged commit 098ad56 into main Feb 9, 2024
14 checks passed
@mattsse mattsse deleted the evalir/fix-additional-fields-support branch February 9, 2024 16:43
@mattsse mattsse mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evalir @mattsse