feat: add OptimismExecutionPayloadV3 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alloy project does not intend to house any non-Ethereum structs. this whole file belongs in a separate repo |
|
this should be in there for ease of use, at least for the time being because we already have some other op types, but once stable we should remove them yes |
mattsse
requested changes
Mar 1, 2024
| /// This structure maps on the ExecutionPayloadV3 structure of the beacon chain spec. | ||
| /// | ||
| /// See also: <https://github.com/ethereum/execution-apis/blob/6709c2a795b707202e93c4f2867fa0bf2640a84f/src/engine/shanghai.md#executionpayloadv2> | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] |
There was a problem hiding this comment.
this should also reference the op spec:
There was a problem hiding this comment.
this should also reference the op spec:
sure, proposed here #244
mattsse
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
Evalir
approved these changes
Mar 2, 2024
|
@DaniPopes is the clippy relevant? otherwise good to merge |
|
@prestwich nope, clippy is unrelated—see proptest fix: proptest-rs/proptest#427 |
|
Tracking wrt OP types #243 |
This was referenced Mar 2, 2024
mattsse
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Mar 3, 2024
Updates `alloy-rpc-types` and `alloy-rpc-trace-types` to `52bf7125d944e8a389371be503035724dfde5657`, which contains alloy-rs/alloy#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Towards paradigmxyz/reth#6871
Solution
Adds specific type for
OptimismExecutionPayloadV3to be used inBuiltPayload. Very similar toExecutionPayloadV3, adds optimism-specific fieldparent_beacon_block_rootPR Checklist