feat: derive Hash for TypedTransaction
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for some caches in Foundry
onbjerg
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
prestwich
requested changes
Mar 12, 2024
DaniPopes
approved these changes
Mar 12, 2024
|
Blocked on c-kzg release on crates |
|
@gakonst we have not released c-kzg 1.0 on crates yet: https://crates.io/crates/c-kzg |
|
Published now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is needed for some caches in Foundry
Solution
This was previously blocked by KZG types not being
HashPR Checklist