Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-types): tracing/txpool rpc types, and additional ergonomics #29

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Nov 17, 2023

Motivation

Adds types necessary for foundry-rs/foundry#6256, which we didn't have before as we didn't have use for them. Also, some nice ergonomics were missing that we used from previous types

Solution

Add the types, add ergonomics

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on block number type

crates/rpc-types/src/eth/trace/filter.rs Show resolved Hide resolved
@Evalir Evalir merged commit 29761eb into main Nov 17, 2023
17 checks passed
@Evalir Evalir deleted the evalir/new-rpc-types-1 branch November 17, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants