Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update comments #521

Merged
merged 1 commit into from
Apr 12, 2024
Merged

update comments #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rpc-types/src/eth/transaction/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pub enum ConversionError {
/// Missing `to` field for EIP-4844 transaction.
#[error("missing `to` field for EIP-4844 transaction")]
MissingTo,
/// Missing `chainId` field for EIP-1559 transaction.
/// Missing `blobVersionedHashes` field for EIP-4844 transaction.
#[error("missing `blobVersionedHashes` field for EIP-4844 transaction")]
MissingBlobVersionedHashes,
}
5 changes: 3 additions & 2 deletions crates/rpc-types/src/eth/transaction/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ pub struct Transaction {
pub access_list: Option<AccessList>,
/// EIP2718
///
/// Transaction type, Some(2) for EIP-1559 transaction,
/// Some(1) for AccessList transaction, None for Legacy
/// Transaction type,
/// Some(3) for EIP-4844 transaction, Some(2) for EIP-1559 transaction,
/// Some(1) for AccessList transaction, None or Some(0) for Legacy
#[serde(
default,
rename = "type",
Expand Down
Loading