feat: use reth-rpc-types #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
mattsse
force-pushed
the
matt/replace-rpc-types-with-reth-rpc-types
branch
from
8d7efb9
to
f6d8525
Compare
mattsse
force-pushed
the
matt/replace-rpc-types-with-reth-rpc-types
branch
from
f6d8525
to
34074fe
Compare
7 tasks
DaniPopes
requested changes
Dec 24, 2023
Evalir
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move all of reth-rpc-types to alloy-rpc-types.This moves commonly used types, tracer and eth namespace types from reth.
The transaction types are removed here because they will be added via #83
This likely needs a bunch of followup PRs but should unblock foundry-rs/foundry#6219
this is still a bit messy and I think we want to divide this up further,
perhaps we even want:
rpc-eth-core-types (this is for things like BlockId BlockNumber) etc.
rpc-eth-types (with common namespaces)
rpc-tracer-types
rpc-common (like serde_helpers)
rpc-engine-types
rpc-relay/beacon-types