Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deserialize EthNotification from params field #93

Merged
merged 3 commits into from
Dec 24, 2023
Merged

fix: deserialize EthNotification from params field #93

merged 3 commits into from
Dec 24, 2023

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Dec 23, 2023

Closes #92

@leruaa leruaa requested a review from prestwich as a code owner December 23, 2023 22:04
@prestwich
Copy link
Member

Thank you, I've added a test and done some cleanup of the nested conditionals :) Will merge when tests pass

@prestwich prestwich merged commit 3b1c310 into alloy-rs:main Dec 24, 2023
17 checks passed
@leruaa leruaa deleted the fix_pub_sub_item_deserialize branch October 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect Deserialize for PubSubItem::Notification
2 participants
@leruaa @prestwich