Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trace_filter method #946

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

this should mark trace_filter as done here #926

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty.

this should be moved to the traceApi trait instead and use &

@DoTheBestToGetTheBest
Copy link
Contributor Author

ty.

this should be moved to the traceApi trait instead and use &

ty so much for your fast review, changes has been made right now

crates/provider/src/ext/trace.rs Outdated Show resolved Hide resolved
crates/provider/src/ext/trace.rs Outdated Show resolved Hide resolved
@mattsse mattsse merged commit 8211239 into alloy-rs:main Jun 19, 2024
22 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* Update trait.rs

* Update trait.rs

* Update trace.rs

* Update trace.rs

* use ref

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants