feat(provider): LRUCache Layer #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jun 22, 2024
mattsse
requested changes
Jun 24, 2024
yash-atreya
changed the title
yash-atreya
requested review from
DaniPopes,
gakonst,
onbjerg and
prestwich
as code owners
mattsse
requested changes
Oct 4, 2024
crates/provider/src/layers/cache.rs
Outdated
| ) -> TransportResult<Option<Block>> { | ||
| let hash = RequestType::new("eth_getBlockByNumber", (number, hydrate)); | ||
|
|
||
| cache_get_or_fetch!(self, hash, self.inner.get_block_by_number(number, hydrate)) |
There was a problem hiding this comment.
this is problematic because of reorgs, we'd need to track chain height somehow, but out of scope for this pr imo
mattsse
requested changes
Oct 4, 2024
mattsse
requested changes
Oct 5, 2024
|
@mattsse addressed the suggestions |
mattsse
requested changes
Oct 7, 2024
| let req = RequestType::new("eth_getBlockReceipts", (block,)); | ||
|
|
||
| let redirect = | ||
| !matches!(block, BlockId::Hash(_) | BlockId::Number(BlockNumberOrTag::Number(_))); |
There was a problem hiding this comment.
the number case is also slightly problematic, but we can worry about this separately
| async fn get_logs(&self, filter: &Filter) -> TransportResult<Vec<Log>> { | ||
| let req = RequestType::new("eth_getLogs", filter.clone()); | ||
|
|
||
| let params_hash = req.params_hash().ok(); |
There was a problem hiding this comment.
this is also a bit nuanced because the blockrange variants allows the server to chose the range for example if upper bound is missing
mattsse
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref: #770
Solution
keyis the hash of the request and its params.Overrides the following RPC methods
get_block_by_numberget_block_by_hashget_block_receiptsget_proofget_storage_atget_code_atget_transaction_countget_logsget_transaction_by_hashget_raw_transaction_by_hashget_transaction_receiptPR Checklist