feat(network): Add input method to TransactionResponse
#959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moricho
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
moricho
changed the title
input method to TransactionResponseinput method to TransactionResponse
mattsse
requested changes
Jun 23, 2024
mattsse
approved these changes
Jun 25, 2024
crates/network/src/ethereum/mod.rs
Outdated
| @@ -62,4 +63,8 @@ impl TransactionResponse for alloy_rpc_types_eth::Transaction { | |||
| fn gas(&self) -> u128 { | |||
| self.gas | |||
| } | |||
|
|
|||
| fn input(&self) -> Bytes { | |||
There was a problem hiding this comment.
wdyt @DaniPopes Bytes or &[u8] ?
There was a problem hiding this comment.
&Bytes would be the best choice here
There was a problem hiding this comment.
I guess we can reasonably assume that every tx always has an input, so that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be nice to have a method to get input data from
TransactionResponse.During my development, there was a situation in which I wanted to know what method was being called and with what arguments from
TransactionResponse.Solution
Adds
inputmethod toTransactionResponseand implements it toTransactionResponsetype for eachNetworkPR Checklist